Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGDSTRM-9751 - JOSDK and fabric8 update #863

Merged
merged 3 commits into from
Feb 2, 2023
Merged

MGDSTRM-9751 - JOSDK and fabric8 update #863

merged 3 commits into from
Feb 2, 2023

Conversation

biswassri
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the operator changes related to operator label Jan 31, 2023
MikeEdgar
MikeEdgar requested changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing - the controller still needs to provide the event source.

operator/src/main/java/org/bf2/operator/controllers/ManagedKafkaController.java Outdated Show resolved Hide resolved
MikeEdgar
MikeEdgar approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

rareddy
rareddy approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@biswassri biswassri changed the title JOSDK and fabric8 update MGDSTRM-9751 - JOSDK and fabric8 update Feb 1, 2023
@biswassri
Copy link
Contributor Author

Tested out the changes, created KI and smoke test successfully.

shawkins
shawkins approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MikeEdgar MikeEdgar added this to the 0.33.0 milestone Feb 2, 2023
@biswassri biswassri merged commit 36ea2b6 into bf2fc6cc711aee1a0c2a:main Feb 2, 2023
@biswassri biswassri deleted the operator-upgrade branch February 2, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rareddy rareddy rareddy approved these changes

@shawkins shawkins shawkins approved these changes

@MikeEdgar MikeEdgar MikeEdgar approved these changes

Assignees
No one assigned
Labels
operator changes related to operator
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
4 participants
@biswassri @rareddy @shawkins @MikeEdgar