Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGDSTRM-10052] Set Strimzi bundle install plan to Manual #830

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

MikeEdgar
Copy link
Contributor

Changes the Strimzi bundle subscription's install plan approval to Manual when not already set.

This may be tested with kas-installer and the branch in bf2fc6cc711aee1a0c2a/kas-fleet-manager#1387 (until accepted/merged).

Current state of KFM in standalone mode will deploy Strimzi with the Automatic install plan approval and without the necessary labels for FSO to find the subscription. The KFM PR adds the labels to match the addon installation method.

Signed-off-by: Michael Edgar <medgar@redhat.com>
@MikeEdgar MikeEdgar added this to the 0.31.0 milestone Nov 7, 2022
@github-actions github-actions bot added the operator changes related to operator label Nov 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikeEdgar
Copy link
Contributor Author

@biswassri , @vbusch , @shawkins - please have a look if you get a moment. This one is relatively small and I'd like to get it in 0.31.0

Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@biswassri biswassri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MikeEdgar MikeEdgar merged commit 4c35835 into bf2fc6cc711aee1a0c2a:main Nov 11, 2022
@MikeEdgar MikeEdgar deleted the MGDSTRM-10052 branch November 11, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
operator changes related to operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants