Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚰️ Remove invalid PHPDoc from stubs #220

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Conversation

nxu
Copy link
Contributor

@nxu nxu commented Aug 22, 2023

This PR removes invalid PHPDoc return types from the stubs.

Return type hints added previously are excellent, but currently the docblocks of the generated policies don't match those, and cause errors in static analysis. PHPStan for example throws the following error:

  19     PHPDoc tag @return with type bool|Illuminate\Auth\Access\Response is not subtype of native type bool.

@bezhanSalleh bezhanSalleh merged commit 62b5ee5 into bezhanSalleh:main Sep 16, 2023
@bezhanSalleh
Copy link
Owner

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants