fix: Fixed append test failures #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 24, 2021
storage.go
Outdated
|
|
||
| // If the object exists, we should set the offset to the next append position. | ||
| headInput := &service.HeadObjectInput{} | ||
| headOutput, err := s.bucket.HeadObjectWithContext(ctx, rp, headInput) |
There was a problem hiding this comment.
As described in GSP-134: https://github.com/beyondstorage/go-storage/blob/master/docs/rfcs/134-write-behavior-consistency.md#services-implementations
We need to delete this file instead of update append position.
There was a problem hiding this comment.
Oh, you are right, I should delete this object.
Xuanwo
approved these changes
Aug 24, 2021
|
Nice work! |
This was referenced Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Fixed append test failures