feat(datatrak): RN-1408: Move ProjectSelectForm to ui-components #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexd-bes
approved these changes
Sep 18, 2024
| @@ -21,6 +22,20 @@ const ListWrapper = styled.div` | |||
| } | |||
| `; | |||
|
|
|||
| type ListItemType = Record<string, unknown> & { | |||
There was a problem hiding this comment.
Thoughts on adding this to ui-components too, since it's the same as another component uses?
|
|
||
| // explicity set the types so that the overrides are applied, for the `button` prop | ||
| // explicitly set the types so that the overrides are applied, for the `button` prop |
| @@ -126,6 +116,7 @@ export const ListItem = ({ item, children, onSelect }: ListItemProps) => { | |||
|
|
|||
| return ( | |||
| <li> | |||
| {/*@ts-ignore*/} | |||
| onRequestAccess: (projectCode: Project['code']) => void; | ||
| projects?: Project[]; | ||
| isLoading: boolean; | ||
| onConfirm: (data: Record<string, any>) => void; |
There was a problem hiding this comment.
Suggested change
| onConfirm: (data: Record<string, any>) => void; | |
| onConfirm: (data: {projectId: string}) => void; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: feat(datatrak): RN-1408: Move ProjectSelectForm to ui-components
Changes: