Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timesync): NASS-1474: Store time offset between central and facility servers #7253

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

feat(timesync): NASS-1474: Store time offset between central and facility servers #7253

wants to merge 22 commits into from
+63 −17

Conversation

dannash100
Copy link
Contributor

@dannash100 dannash100 commented Feb 21, 2025 •
edited
Loading

Changes

Very wip just was confirming what the actual requirements where.

  • Use timesync to store an offset +/- in ms of time between facility and central server to be used in auditing.

one question tho do yall rekon we should do

timesync.destroy()

On SIGTERM or not important 🤔

Deploys

  • Deploy to Tamanu Internal

Remember to...

  • ...write or update tests
  • ...add UI screenshots and testing notes to the Linear issue
  • ...add any manual upgrade steps to the Linear issue
  • ...update the config reference, settings reference, or any relevant runbook(s)
  • ...call out additions or changes to config files for the deployment team to take note of

@dannash100 dannash100 changed the title Feat/nass 1474 store time offset from central feat(timesync): NASS-1474: Store time offset between central and facility servers Feb 21, 2025
@dannash100 dannash100 marked this pull request as ready for review February 24, 2025 02:35
@dannash100 dannash100 requested review from a team, edmofro and chris-bes as code owners February 24, 2025 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmofro edmofro Awaiting requested review from edmofro edmofro is a code owner

@chris-bes chris-bes Awaiting requested review from chris-bes chris-bes is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dannash100