Epic: Program Registries Phase 2 #7231
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update programRegistry.stories.jsx * update form stories * refactor program registry fetch * Update forms.stories.jsx * feat(tamanuWeb): SAV-869: Condition category field model (#7196) * add condition category field * remove white space changes * feat(tamanuWeb): SAV-869: Add program registry condition category field (#7189) * Update PatientProgramRegistryForm.jsx * Update PatientInfoPane.jsx * update form data state * data migration * mobile migration * docs * Update patient_program_registration_conditions.md * refactor for usability * Update patient_program_registration_conditions.md * Update PatientProgramRegistration.test.js * clear category on condition clear * remove console log * Update programRegistry.stories.jsx * add missing translations * Update PatientProgramRegistryForm.jsx * fix up queries
|
Android builds 📱
|
🍹
|
Comment on lines
28
to
36
| Suspected: 'Suspected', | ||
| 'Under investigation': 'Under investigation', | ||
| Confirmed: 'Confirmed', | ||
| Unknown: 'Unknown', | ||
| Disproven: 'Disproven', | ||
| Resolved: 'Resolved', | ||
| 'In remission': 'In remission', | ||
| 'Not applicable': 'Not applicable', | ||
| 'Recorded in error': 'Recorded in error', |
There was a problem hiding this comment.
Unsure about these keys?
There was a problem hiding this comment.
I agree - as discussed, let's change them to camelCase keys
| conditions: [ | ||
| { | ||
| conditionId: programRegistryCondition.id, | ||
| category: PROGRAM_REGISTRY_CONDITION_CATEGORIES.CONFIRMED, |
There was a problem hiding this comment.
How is this working?
There was a problem hiding this comment.
Oh okay I see why, this is a POST, we're sending undefined, it probably saves it as 'Unknown' and we never check for this value later 🤔
* update program view layout * fix query keys * translations * pr fixes * Update PatientProgramRegistryForm.jsx
…7254) * Make span as big as possible as we no longer need that padding effect * Wrap button with tooltip to avoid weird display issues * Update outline color to match figma * Include the condition category on the list * Increase length check for tooltip visibility * No point ordering by date in backend * Create two groups of conditions * Set overflow behavior * Use constant * Add TODO, this will be followed up on another PR if needed * Replace mapper function for a component for readability Co-authored-by: Tom Caiger <caigertom@gmail.com> * Whoops, prop syntax needed destructuring * Add translation for condition category Co-authored-by: Tom Caiger <caigertom@gmail.com> * Add translation to condition name * Display translated title and always show tooltip * Only display tooltip if element overflows * Properly style * Translate content and sort by it, plus refactor display component --------- Co-authored-by: Tom Caiger <caigertom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: Program Registries Phase 2