Add tests #21
Open
Add tests #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests for managing Forge workers. It mocks the necessary calls to the Forge API client and asserts that, given a specified config file and array of worker resources returned by Forge, the config file will be updated correctly and the expected calls will be made to create or delete additional workers.
One small changes to unrelated code was necessary to make these tests work for now. I actually kind of like it... but I'm open to feedback and alternatives—the
config:pushcommand now passes the console output into the sync classes as a closure, so that output from the sync classes can be expected/asserted on in tests. Commands'->getOutput()methods return null in testing because the output methods are all mocked, so in order to test this we have to actually call->info(),->warn(), etc. directly.All these tests pass, I'll add a GitHub Action in another PR to run them automatically and prove it 😅