Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin reference for PHAR compilation. #366

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kleinmann
Copy link

I've gotten errors when using the compiled PHAR and it had an inflated size due to including the already present PHAR from builds/expose. This PR fixes the PHAR configuration to match the documented output location and to use the correct main entrypoint.

@what-the-diff
Copy link

what-the-diff bot commented Feb 2, 2023

  • The box.json file was changed to add an output and main property
  • A new .gitignore rule was added for the expose binary in builds/expose
  • composer's bin entry now points directly at the expose executable instead of a symlinked version in builds/expose

@kleinmann
Copy link
Author

  • The box.json file was changed to add an output and main property
  • A new .gitignore rule was added for the expose binary in builds/expose
  • composer's bin entry now points directly at the expose executable instead of a symlinked version in builds/expose

Ignore the last point, that was an oversight from earlier tests and was since removed 🙂

tompetko pushed a commit to ninedigit/expose that referenced this pull request Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant