Stablize sorts used by path finders #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe move these comparisons to a single spaceship operator, since we're now in c++20 land? |
These weak comparisons use different logic to the regular comparisons. I can add three-way comparison (as an addition), but it won't be used in the current code - maybe better to wait until other/future code needs it? |
lostsquirrel1
force-pushed
the
BAR105-stable_sort_pathing_priority_queues
branch
from
0fce1b3 to
b423e08
Compare
sprunk
reviewed
Dec 8, 2024
sprunk
approved these changes
Dec 12, 2024
lhog
reviewed
Dec 12, 2024
lostsquirrel1
changed the title
lhog
reviewed
Dec 12, 2024
sprunk
approved these changes
Dec 12, 2024
|
Thanks you for fixing this guys ❤️ Can't wait to try multi from OpenBSD with non-OpenBSD players & friends |
saurtron
added
the
status: candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::priority_que doesn't guarantee that the sorts it performs is stable. This could potentially lead to a desync between different platforms or build chains.