Use cmake import targets part 1 #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-morales
commented
Oct 25, 2024
| @@ -257,6 +257,18 @@ macro (catch_regex_group pattern group var str) | |||
| endmacro (catch_regex_group) | |||
|
|
|||
|
|
|||
| # macro that adds "fontconfig fontconfig-1" to find_library on win32 | |||
| macro(find_fontconfig_hack) | |||
There was a problem hiding this comment.
I'm sorry for adding this, I don't know why the windows libraries are named weirdly in our dependencies
p2004a
reviewed
Oct 26, 2024
@p2004a Good point, I do have a windows install I can try it on, so I'll get to that and report back |
|
@p2004a I verified that this builds on windows + MSVC (btw do we have a CI machine that we can have for that? We might be able to get something with github runners or appveyor for free since BAR is open source)
Ok that was just the ALL_BUILD which fails on master anyway but engine-legacy builds fine :) |
p2004a
reviewed
Nov 1, 2024
n-morales
force-pushed
the
use-cmake-import-targets
branch
from
2419269 to
0d1da54
Compare
…d of just the first two
…s dependencies don't install libpng properly
… targets; use import targets
n-morales
force-pushed
the
use-cmake-import-targets
branch
from
0d1da54 to
9192311
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first batch of conversions to cmake import targets. There are a lot more beyond this
I've tested these with the v2 builds for both windows and linux -- ideally this shouldn't affect anything beyond the way in which cmake finds things but it should probably be tested thoroughly.
Libraries are separated into different commits, so I can split this further if needed.