Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minimum bonus 0 in all cases #867

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

AntlerForce
Copy link
Collaborator

The special -99 minimum value that the bonus selector gets in singleplayer would imply support for using bonus to debuff AI, but this value does not appear to do anything below 0. This PR sets this to 0 in all cases instead of multiplayer-only.

@AntlerForce AntlerForce merged commit 15c2c76 into beyond-all-reason:master Dec 23, 2024
@kroIya
Copy link
Contributor

kroIya commented Dec 23, 2024

Did it really not work? The handicap works in scenarios, something's not right here.

@AntlerForce
Copy link
Collaborator Author

AntlerForce commented Dec 23, 2024

Did it really not work? The handicap works in scenarios, something's not right here.

Negative values didn't have any visible interface change in the player list, unlike the positive bonus values which did.

@kroIya
Copy link
Contributor

kroIya commented Dec 23, 2024

Negative values didn't have any visible interface change in the player list, unlike the positive bonus values which did.

I tried researching this myself a while ago but gave up, it really is unintuitive. Negative handicap worked, but it stopped showing up in the player list at some point. Instead, metal spots on the map itself will show reduced values when viewed from the handicapped team's perspective.

Mechanically, it also worked last time I checked.

I'll experiment with this again this evening to confirm, but it might warrant a revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants