-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use image-compare widget #690
Conversation
It won't work unless you have #689 as well |
Yeah. I cherry picked the commit, now it works. Sorry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. A shame we don't have the slider for RCAS off/on and msaa/taa. Those would also benefit from it.
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
Hopefully we do a pass on the images before release For msaa/taa I'm not sure whether it's appropriate to compare them. I think no-aa/msaa & no-aa/taa could make more sense? |
The section titled "Temporal Anti-Aliasing" has an image that is a side-by-side comparison of TAA and MSAA. It would just be an improvement to replace that specific image with a slider comparison. Whether it's a good comparison or not is orthogonal. But a good reason to compare MSAA and TAA would be a way to point out the various artifacts and improvements each algo have (typically MSAA is still bad with specular highlights, while TAA fixes them). |
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll re-render some of the images and tweak the CSS a bit
Use the image-compare widget where it's obvious to do so.
This depends on #689 and cherry-picks #680
The Tonemapping section needs new images that are more suitable for this
and in general it would be good to standardise the placement of and size of titles in the images.Thanks to @nicopap we can use markup to add titles to the images