Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed explicit branch="main" in dependencies #186

Merged
merged 1 commit into from
Jul 13, 2021
Merged

removed explicit branch="main" in dependencies #186

merged 1 commit into from
Jul 13, 2021

Conversation

xenual
Copy link
Contributor

@xenual xenual commented Jul 13, 2021

Support was added as of 1.53.0, I believe this is no longer needed.

https://blog.rust-lang.org/2021/06/17/Rust-1.53.0.html#head-branch-name-support-in-cargo

Closes #171

@xenual
Copy link
Contributor Author

xenual commented Jul 13, 2021

Also, I'm not sure how to link issues but this commit fixes #171 .

@alice-i-cecile
Copy link
Member

Also, I'm not sure how to link issues but this commit fixes #171 .

Simply say "Fixes #171" in the initial message :) Should work even with edits, and you can use "closes" or "resolves" instead IIRC.

@xenual
Copy link
Contributor Author

xenual commented Jul 13, 2021

Ooh, I think I get it now, thank you :)

@cart cart merged commit 7e5f94f into bevyengine:master Jul 13, 2021
@xenual xenual deleted the remove-dependency-fix branch July 13, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove manual "main" branch from git dependency quickstart
3 participants