Fix "unknown conversion error" on Windows #136
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, yesterday I also saw this bug #133 on Windows, which breaks my build environment.
I do not know how to pass the conversion parameter to
bin.js
, but I think it can be fixed by providing two binary filescson2json.js
andjson2cson.js
.Also, it seems this check sometimes gives wrong conversion directions with some filenames on Linux. For example,
json2cson Ericson2jsonline.json
will actually executecson2json
instead because of the filename.Please have a look. Thank you!