Add typescript definition

[dderevjanik]

Hi,

I would like to contribute with typescript definition file (index.d.ts) to project.

There's no typings in DefinetelyTyped and TS project has to create their own d.ts everytime. So, instead of creating PR to DefinitelyTyped, it makes more sense to create PR directly to this Repo, because repo wasn't updated for a while and it is not going (probably) to change API.

Several IDEs would also benefits from this and they will be able to provide intellisense for user. This is not only exclusive for Typescript devs but it could be used for JS aswell.

[jskrnbindra]

Ya adding typings can be a great help.

[jskrnbindra]

I think

export default fuzzysearch;

would be better here.
@dderevjanik

[dderevjanik]

I tried it, but now I'm getting this error

[ts] Cannot invoke an expression whose type lacks a call signature. Type 'typeof 'fuzzysearch'' has no compatible call signatures.

export = fuzzysearch works as expected.

[pascaliske]

@jskrnbindra @dderevjanik Without the empty namespace but with the default export it should work.
The default export would match the libraries real export, I think.

[noahm]

As weird as it looks, these typings are correct as-is. (It matches the underlying implementation of module.exports = fuzzysearch;)

Writing the types as a default export would work in some cases but not others, depending on which module loader a given project is using. Would love to see this get merged! 🙏

[dderevjanik]

@bevacqua Please, is there something I can do better or different to make this PR merged ? Thanks

[chenyong]

What happened to this issue?

[dderevjanik]

still waiting for response

[chenyong]

hello? @bevacqua

[remcohaszing]

FWIW I created @types/fuzzysearch before I noticed this PR. It’s effectively the same.

[jskrnbindra]

Sorry folks. I don't remember reviewing this PR. Nor do I have write permissions on this repo.