Fixes #7 - sync DOM with scope.model #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| app.controller('RepeatCtrl', ['$scope', | ||
| function ($scope) { | ||
| app.controller('RepeatCtrl', ['$scope', 'dragulaService', |
There was a problem hiding this comment.
doesn't seem like it needs dragulaService
There was a problem hiding this comment.
Yes, I forgot to remove it... why jshint didn't tell anything? It doesn't check example.js?
There was a problem hiding this comment.
Correct. .jshintignore ignores example directory
There was a problem hiding this comment.
Ok I will remove it soon, I recalled why I left it there.. I wanted to try removeOnSpill, but I forgot on it while writing else.. now when I test it I see that if I use dragulaService.options($scope, 'another-bag', {removeOnSpill:true}) it disconnect models. I have to repair it.
|
Looks great |
bevacqua
added a commit
that referenced
this pull request
Aug 19, 2015
Fixes #7 - sync DOM with scope.model
|
I made you a collaborator so you can push to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only one problem I see here... if some use filtered ngRepeat. In such case DOM element index will differ from model index. I will solve this another time.