Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC on Resources for OSPOs #2045

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

pagrubel
Copy link
Member

@pagrubel pagrubel commented Mar 25, 2024

Description

Resources for Open Source Program Offices and Projects

Author: @pagrubel
EB Member: @<eb-member-id>

Resolves #1582

PR checklist for files displayed on bssw.io site

  • [Author] @mention the BSSw.io editorial board member @<eb-member-id> in Description above assigned to shepherd your PR.
  • [Author] Add the <issue-id> in the Description above for the associated GitHub Issue.
  • [ ] [Author] Ensure wikize_refs.py -i <base>.md is run and commit (if using wikize_refs.py).
  • [Author] Inspect the content in the *.md file(s) as rendered in GitHub for this PR.
  • [EB Mem] Assign this PR to the EB member <eb-member-id>.
  • [EB Mem] Assign this PR to the author of the PR <pr-author-id>.
  • [EB Mem] Add one or more Reviewers.
  • [EB Mem] Add label content: <content-type> for the type of contribution.
  • [EB Mem] Add to Project Content Development (see Content Development).
  • [EB Mem] Add meta-data to the *.md file(s) (set Publish: yes).
  • [EB Mem] Add label preview (so PR branch will be merged to 'preview' branch and watch for possible merge failures).
  • [EB Mem] Rebuild preview site and confirm new content is there, renders correctly and is returned in searches.
  • [Author] Make any final changes to the PR based on feedback.
  • [ ] [Author] Ensure wikize_refs.py -i <base>.md is run and commit (if using wikize_refs.py).
  • [EB Mem] Rebuild preview site and re-confirm content looks correct.
  • [EB Mem] Ensure at least one reviewer signs off on the final changes.
  • [EB Mem] Move the PR to "Ready to Publish" in Content Development.
  • [EB Mem] Leave comment and @mention @betterscientificsoftware/bssw-maint (BSSw Maint) asking to carry out final publication steps.
  • [BSSw Maint] Verify that all needed files are present in the PR (article, images, updates to Site/Homepage.md carousel and/or Site/Announcements/Announcements.md as appropriate).
  • [BSSw Maint] Merge PR. (Should automatically move to "Done" in Content Development.)
  • [BSSw Maint] Verify new contribution shows up on bssw.io as expected.

NOTE:

  • Checklist items prefixed with [Author] are expected to be performed by the author of the PR or can be performed by the author.
  • Checklist items prefixed with [EB Mem] must be performed by a BSSw.io Editorial Board (EB) Member.
  • Checklist items prefixed with [BSSw Maint] must be performed by someone in the @betterscientificsoftware/bssw-maint team (hint: type @, b, s, s, w, -, m to auto-complete to @betterscientificsoftware/bssw-maint).

@pagrubel pagrubel changed the title Start CC on Resources for OSPOs CC on Resources for OSPOs Mar 25, 2024
@pagrubel pagrubel added content: curated For curated content preview Merge PR to the 'preview' branch to allow display on preview.bssw.io labels Mar 25, 2024
@pagrubel
Copy link
Member Author

@davidbernholdt Would you know why the check for external contributions is failing. I'm a team member.

@markcmiller86 markcmiller86 self-requested a review March 25, 2024 18:04
@pagrubel pagrubel force-pushed the issue#1582/cc-article-resources-for-OSPO branch from 8097369 to c316cbf Compare March 25, 2024 22:03
@pagrubel
Copy link
Member Author

@markcmiller86 I think this is ready for your review.

@pagrubel pagrubel marked this pull request as ready for review March 25, 2024 22:33
Copy link
Member

@markcmiller86 markcmiller86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've proposed some minor edits. Please have a look.

CuratedContent/ResourcesforOSPO.md Outdated Show resolved Hide resolved
CuratedContent/ResourcesforOSPO.md Outdated Show resolved Hide resolved
CuratedContent/ResourcesforOSPO.md Outdated Show resolved Hide resolved
CuratedContent/ResourcesforOSPO.md Show resolved Hide resolved
CuratedContent/ResourcesforOSPO.md Outdated Show resolved Hide resolved
Committing accepted changes.

Co-authored-by: Mark C. Miller <miller86@llnl.gov>
@pagrubel
Copy link
Member Author

@markcmiller86 I made the changes except where I noted with a comment. I'm trying to check in on preview but that isn't working right now.

Co-authored-by: Mark C. Miller <miller86@llnl.gov>
@pagrubel
Copy link
Member Author

@markcmiller86 I've checked this on the preview site and am ready to merge it. Would you give it one more look, thanks!

Copy link
Member

@markcmiller86 markcmiller86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pagrubel pagrubel merged commit c2fadf8 into main Mar 26, 2024
2 checks passed
@pagrubel pagrubel deleted the issue#1582/cc-article-resources-for-OSPO branch March 26, 2024 21:12
@pagrubel pagrubel removed the preview Merge PR to the 'preview' branch to allow display on preview.bssw.io label Mar 26, 2024
@bartlettroscoe bartlettroscoe added this to the 2024-04 Digest milestone Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content: curated For curated content
Projects
Development

Successfully merging this pull request may close these issues.

Resources for Open Source Program Offices
3 participants