Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added directory deleted files tracking #69

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

Leocete
Copy link
Contributor

@Leocete Leocete commented Jul 13, 2021

No description provided.

@BetaHuhn BetaHuhn changed the base branch from master to develop July 14, 2021 13:13
@BetaHuhn
Copy link
Owner

Thanks for taking the time to create this great PR!

One problem I see is if you would manually add a file to a target directory and it doesn't also exist in the source it would be deleted on the next sync which is probably not something you want.

I think it might be good to add an option to enable this new behavior on a per directory basis. Maybe a deleteOrphaned key similar to the already existing replace key.

@BetaHuhn
Copy link
Owner

I will add the option myself and then will merge your PR.

@BetaHuhn BetaHuhn linked an issue Jul 14, 2021 that may be closed by this pull request
@BetaHuhn BetaHuhn added the feature request Idea for a new feature label Jul 14, 2021
@BetaHuhn BetaHuhn merged commit 4a9f0ed into BetaHuhn:develop Jul 14, 2021
@BetaHuhnBot
Copy link
Collaborator

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@BetaHuhn
Copy link
Owner

Thanks again @Leocete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Idea for a new feature released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deletion of a file does not trigger the sync action.
3 participants