Deletion of a file does not trigger the sync action.

[Leocete]

🐞 Describe the bug

Deletion of a file does not trigger the sync action.

📚 To Reproduce

1. Configure repo sync action on a particular directory
2. Add some files there.
3. Delete one of the files.

💡 Expected behavior

A new PR opened with file deletion.

🖼️ Screenshots

If applicable, add screenshots to help explain your problem.

⚙️ Environment

• Action version: [e.g. v1.0.0]

📋 Additional context

Add any other context about the problem here.

[Leocete]

A problem is here in that command:

repo-file-sync-action/src/git.js

Line 126 in 0fc61d9

`git status --porcelain`,

It somehow can't see deleted files.

[BetaHuhn]

Hey @Leocete,

Thanks for taking the time to open this issue!

It somehow can't see deleted files.

git status --porcelain should list all deleted files as well.

The problem is repo-file-sync-action currently can't delete files when syncing two directories. This is not documented anywhere explicitly, which was not ideal on my part.

It only copies files which exist in the source directory to their target destination and creates a commit if there were any changes. It thus doesn't delete any files in the target directory. As you can see here:

repo-file-sync-action/src/index.js

Lines 63 to 68 in 0fc61d9

	const isDirectory = await pathIsDirectory(file.source)
	const source = isDirectory ? `${ addTrailingSlash(file.source) }` : file.source
	if (isDirectory) core.warning(`Source is directory`)
	await copy(source, localDestination, file.exclude)

The copying itself is done with fs-extra.

I currently have no fix for this, so you are welcome to propose ideas on how we can implement this in an elegant way!

[BetaHuhn]

One way to fix this would be to get all files for both the source and target and then figure out which files should be copied from the source to the target and which files should be deleted from the target.

Right now it just merges the source directory with the target.

[Leocete]

I opened a PR on that issue - #69

[BetaHuhn]

🎉 This issue is resolved in version v1.9.0 🎉

You have to enable deleting files in the target manually with the deleteOrphaned option.

To use the latest version, use the Action with the v1 tag:

uses: BetaHuhn/repo-file-sync-action@v1

Or the latest tag:

uses: BetaHuhn/repo-file-sync-action@latest