Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demander à sélectionner au moins une option à l’envoi d’une sollicitation #913

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Demander à sélectionner au moins une option à l’envoi d’une sollicitation #913

merged 2 commits into from
Mar 18, 2020

Conversation

n-b
Copy link
Contributor

@n-b n-b commented Mar 18, 2020

refs #888

@n-b n-b force-pushed the make-options-required branch from 6140cbb to 3b99faa Compare March 18, 2020 10:03
@n-b n-b force-pushed the make-options-required branch from 3b99faa to f014663 Compare March 18, 2020 11:07
@n-b n-b force-pushed the make-options-required branch from f014663 to 5a83646 Compare March 18, 2020 13:07
@n-b n-b merged commit f88ba1f into master Mar 18, 2020
@n-b n-b deleted the make-options-required branch March 18, 2020 13:12
n-b added a commit that referenced this pull request Mar 18, 2020
@n-b
Fix Uglifier complaining about ES6 syntax
5d84005 
In #913, we use some ✨fancy ES6 javascript✨ syntax, and Uglifier needs to be made aware of this.

The exact command that fails is RAILS_ENV=production bundle exec rake assets:precompile.

The error message is
> Uglifier::Error: Unexpected token: operator (>). To use ES6 syntax, harmony mode must be enabled with Uglifier.new(:harmony => true)

In development, Uglifier isn’t used 🤷🏻‍♂️.

See lautis/uglifier#127 for context.
This was referenced Mar 18, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucienMLD LucienMLD LucienMLD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@n-b @LucienMLD