Sensible - Mise à jour de VueJs #4741
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jenovateurs
commented
Nov 19, 2024
•
jenovateurs
commented
- Pinia : https://github.com/vuejs/pinia/blob/v2/packages/pinia/CHANGELOG.md
- VueJs : https://github.com/vuejs/core/blob/main/CHANGELOG.md
- Vue-router : https://github.com/vuejs/router/blob/main/packages/router/CHANGELOG.md
- Vue/test-utils : https://github.com/vuejs/test-utils/releases
- Vue-jest : https://github.com/vuejs/vue-jest/releases
- Vue/eslint : https://github.com/vuejs/eslint-config-typescript/releases
|
En attente de validation de l'autre PR pour itérer. |
|
Cette PR devient caduque par rapport à celle de jest non @Shamzic ? |
Shamzic
reviewed
Feb 18, 2025
| @@ -217,6 +217,10 @@ export async function logSurveyLinkClick(req: Request, res: Response) { | |||
| const redirectUrl = await getRedirectUrl(req) | |||
| res.redirect(redirectUrl) | |||
| } catch (error) { | |||
| console.error( | |||
| "Erreur lors de la mise à jour du sondage dans le followup", | |||
There was a problem hiding this comment.
Jusqu'à présent on a les erreurs en anglais
Suggested change
| "Erreur lors de la mise à jour du sondage dans le followup", | |
| "Error: survey update in followup", |
| @@ -59,6 +59,9 @@ export function useVolontaryOrganisations() { | |||
| } catch (error) { | |||
| volontaryOrganisationsLink.value = baseUrl | |||
| updating.value = false | |||
| console.error( | |||
| "Erreur lors de la construction du lien avec JeVeuxAider " + error | |||
There was a problem hiding this comment.
Suggested change
| "Erreur lors de la construction du lien avec JeVeuxAider " + error | |
| "Error: link build with JeVeuxAider ", error |
| @@ -34,6 +34,9 @@ function skipSendEventToRecorder(event: RecorderEvent): boolean { | |||
| getEnvVariable("VITE_STATS_URL") | |||
| getEnvVariable("VITE_STATS_VERSION") | |||
| } catch (e) { | |||
| console.error( | |||
| "Erreur lors de la récupération des variables d'environnements VITE " + e | |||
There was a problem hiding this comment.
Suggested change
| "Erreur lors de la récupération des variables d'environnements VITE " + e | |
| "Error: retrieving Vite environment variables", e |
| @@ -19,6 +19,7 @@ export class StorageService { | |||
| storage.removeItem(storageTest) | |||
| return storedValue === storageTest | |||
| } catch (e) { | |||
| console.error("Erreur lors de la mise à jour des données locales " + e) | |||
There was a problem hiding this comment.
Suggested change
| console.error("Erreur lors de la mise à jour des données locales " + e) | |
| console.error("Error: updating local data", e) |
| @@ -34,6 +35,7 @@ export class StorageService { | |||
| try { | |||
| return JSON.parse(item) | |||
| } catch (e) { | |||
| console.error("Erreur lors du parsage des données " + e) | |||
There was a problem hiding this comment.
Suggested change
| console.error("Erreur lors du parsage des données " + e) | |
| console.error("Error: parsing data", e) |
| @@ -48,7 +48,9 @@ waitForPaq() | |||
| initializeABTestingDimensions() | |||
| }) | |||
| .catch((error) => { | |||
| !isProduction && console.error("Error while loading Matomo:", error) | |||
| if (!isProduction) { | |||
| console.error("Error while loading Matomo:", error) | |||
There was a problem hiding this comment.
Suggested change
| console.error("Error while loading Matomo:", error) | |
| console.error("Error: loading Matomo", error) |
|
Mis à part les logs d'erreurs à mettre en anglais et les conflits avec le package-lock, ça me semble bon. (-: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.