Suppression des mandats révoqués et expirés sur l'espace aidant au bout d'un an #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tut-tuuut
reviewed
Mar 4, 2022
tut-tuuut
reviewed
Mar 4, 2022
tut-tuuut
reviewed
Mar 4, 2022
mrjmad
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
je met un approval parce que si tu veux pouvoir merger les choses. Mais je pense que ca pourrait etre vraiment pas mal de mettre en place les petites simplfications proposés par @tut-tuuut .
liviaribeiro
force-pushed
the
lpr/not_show_over_year_revoked_expired_mandates
branch
from
42c785c
to
dece799
Compare
liviaribeiro
force-pushed
the
lpr/not_show_over_year_revoked_expired_mandates
branch
from
dece799
to
82dea5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌮 Objectif
Suppression des mandats révoqués et expirés sur l'espace aidant au bout d'un an.
🔍 Implémentation
Actualisation de la fonction inactive dans models pour ne pas retourner les mandats expirés ou révoqués depuis un an. Également pour la fonction _get_usagers_dict_from_mandats dans usagers.py
Création de RevokedOverYearMandatFactory et ExpiredOverYearMandatFactory pour les tests.
🏕 Amélioration continue
(optionnel) Documentation, commandes à lancer, variables d'environment, etc
🖼️ Images
(optionnel) Une ou plusieurs captures d'écran