Améliorer l'expérience utilisateur en cas d'erreur explicite FranceConnect #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tut-tuuut
force-pushed
the
ahr/make-it-more-user-friendly-when-fc-error
branch
from
4ce5c28
to
0a4743b
Compare
christophehenry
approved these changes
Jan 24, 2022
tut-tuuut
force-pushed
the
ahr/make-it-more-user-friendly-when-fc-error
branch
from
0a4743b
to
cef8cfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌮 Objectif
Quand FranceConnect nous retourne une erreur explicite, l'erreur n'est pas traitée côté AC et on se contente d'afficher un écran blanc avec un code 403. Il faut aller décoder l'URL pour savoir ce qui s'est passé :
Par exemple ici on demande le scope "gender" et apparemment on ne devrait plus...
🔍 Implémentation
Je propose de réutiliser la fonction
fc_errorquand la requête contient un paramètre "error". Dans ce cas on logue l'erreur et redirige l'utilisateur vers la page de création de mandat avec un message gentil. (À défaut d'être très utile, certes ! On fait c'qu'on peut hein.)Images
Le message explicite remonte dans Sentry et c'est cool :