N'afficher que les départements relatifs à la région sélectionnée, si pertinent #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tut-tuuut
commented
Jan 18, 2022
| @@ -115,14 +115,28 @@ class DepartmentFilter(SimpleListFilter): | |||
| filter_parameter_name = "zipcode" | |||
|
|
|||
| @classmethod | |||
| def generate_filter_list(cls): | |||
| def generate_filter_list(cls, region=None): | |||
There was a problem hiding this comment.
On doit pouvoir faire plus propre dans cette partie-là, mais j'arrivais pas à compiler… ><
mrjmad
approved these changes
Jan 18, 2022
Base automatically changed from
ahr/add-filters-in-habilitation-admin
to
main
January 19, 2022 10:14
tut-tuuut
force-pushed
the
ahr/display-only-region-departments-if-relevant
branch
from
407f415
to
a0a60fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌮 Objectif
Quand on sélectionne un filtre par région dans l'admin, (par ex. grand est) on a toujours les 102 départements qui sont affichés dans le filtre éponyme. Ce serait plus malin de n'afficher que les départements de la région sélectionnée.
🔍 Implémentation
requestpour modifier ce qu'on va chercher dans les lookups.RequestFactoryparce queNonene passe plus comme paramètrerequest)🖼️ Images
C'est quand même plus sympa comme ça :