Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js to 18.14.0 LTS and bump workflow to macos-12 #629

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Update Node.js to 18.14.0 LTS and bump workflow to macos-12 #629

merged 1 commit into from
Mar 17, 2023

Conversation

haslinghuis
Copy link
Member

No description provided.

@haslinghuis haslinghuis added the dependencies Pull requests that update a dependency file label Feb 12, 2023
@haslinghuis haslinghuis self-assigned this Feb 12, 2023
@haslinghuis haslinghuis changed the title Update Node.js to 18.14.0 LTS Update Node.js to 18.14.0 LTS and bump workflow to macos-12 Feb 12, 2023
@blckmn
Copy link
Member

blckmn commented Feb 12, 2023 •
edited
Loading

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> FAIL
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> PASS
  • approver count at least three -> FAIL

@haslinghuis haslinghuis force-pushed the update-node branch 2 times, most recently from 2a773cc to 69da0a7 Compare February 12, 2023 11:21
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

nerdCopter
nerdCopter approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • worked fine locally on Debian 11 (with exception of video export which was already the case)
  • i cannot test macOS build
  • how i tested:
nvm install 18.4
nvm use 18.4
rm -rf node_modules/
yarn install --check-files ; yarn gulp clean ; yarn gulp debug

@haslinghuis
Copy link
Member Author

@ctzsnooze can you check on OSX please

@ctzsnooze
Copy link
Member

Works fine with my old Mojave 10.14 Mac firmware - great work guys!

@haslinghuis haslinghuis merged commit 363484f into betaflight:master Mar 17, 2023
@haslinghuis haslinghuis deleted the update-node branch March 17, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

Assignees

@haslinghuis haslinghuis

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haslinghuis @blckmn @ctzsnooze @nerdCopter