Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PID Tuning Tab #510

Merged
merged 6 commits into from
Feb 15, 2025
Merged

PID Tuning Tab #510

merged 6 commits into from
Feb 15, 2025

Conversation

YarosMallorca
Copy link
Contributor

@YarosMallorca YarosMallorca commented Jan 8, 2025 •
edited
Loading

Currently writing the PID Tuning tab for the Configurator docs.
Most of the descriptions are taken from the Betaflight Configurator tooltips.

Direct link: https://deploy-preview-510.dev.web.betaflight.com/docs/wiki/configurator/pid-tuning-tab

@netlify Netlify
Copy link

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for origin-betaflight-com ready!

Name Link
🔨 Latest commit 9d1ed62
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-com/deploys/67afc344bd4b380008c9d1b6
😎 Deploy Preview https://deploy-preview-510.dev.web.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 9, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within a week.

@YarosMallorca YarosMallorca marked this pull request as ready for review February 14, 2025 21:32
@YarosMallorca YarosMallorca changed the title [In Progress] PID Tuning Tab PID Tuning Tab Feb 14, 2025
@nerdCopter
Copy link
Member

Can you replace all “&” with "? i.e. the slanted quotes for standard quotes.

@nerdCopter
Copy link
Member

nerdCopter commented Feb 14, 2025 •
edited
Loading

Same with the single quotes. ‘ > '.

@nerdCopter
Copy link
Member

At quick review it looks really good. I'll need to read fully next week, or other devs can review as well.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@YarosMallorca
Copy link
Contributor Author

To make your life's easier, most of the things are copied from the Betaflight Configurator tooltips :)

nerdCopter
nerdCopter approved these changes Feb 15, 2025
View reviewed changes
Copy link
Member

@nerdCopter nerdCopter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • approving without full-review. any required fixes can come later.
  • thank you!

@haslinghuis haslinghuis merged commit f54b623 into betaflight:master Feb 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haslinghuis haslinghuis haslinghuis approved these changes

@nerdCopter nerdCopter nerdCopter approved these changes

@ctzsnooze ctzsnooze Awaiting requested review from ctzsnooze

@KarateBrot KarateBrot Awaiting requested review from KarateBrot

@SupaflyFPV SupaflyFPV Awaiting requested review from SupaflyFPV

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YarosMallorca @nerdCopter @haslinghuis