Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable motor stop feature when airmode is enabled #4326

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Feb 2, 2025

This pull request includes an update to the motors.initialize function in the src/js/tabs/motors.js file to enhance the handling of the ESC motor stop feature.

Improvements to ESC motor stop handling:

  • src/js/tabs/motors.js: Modified the .escMotorStop element to disable the input#feature4 input if the "AIRMODE" feature is enabled.

@haslinghuis haslinghuis added this to the 11.0 milestone Feb 2, 2025
@haslinghuis haslinghuis self-assigned this Feb 2, 2025
Copy link

netlify bot commented Feb 2, 2025

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 96280ea
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/67a13a58659aac00095281ce
😎 Deploy Preview https://deploy-preview-4326.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@haslinghuis haslinghuis changed the title Hide motor stop when airmode is enable Hide motor stop when airmode is enabled Feb 2, 2025
@dmak
Copy link

dmak commented Feb 3, 2025

So you are more inclined to have it hidden. Well, if that is a better option compared to have it disabled, then let it be.

@haslinghuis
Copy link
Member Author

@dmak did not know it was exclusive. So makes sense to hide it in configurator. But still like the info to be in documentation too.

@dmak
Copy link

dmak commented Feb 3, 2025

@dmak did not know it was exclusive. So makes sense to hide it in configurator. But still like the info to be in documentation too.

Well, my idea was that if control is disabled, the user may click on (?) button or navigate to wiki to get more info about why it is disabled. If it is hidden then it rings no bell 😉

@nerdCopter
Copy link
Member

nerdCopter commented Feb 3, 2025

i can predict many i can't click it's 😆 -- probably needs an accompanying help-icon/tooltip.

Copy link

sonarqubecloud bot commented Feb 3, 2025

@haslinghuis haslinghuis changed the title Hide motor stop when airmode is enabled Disable motor stop feature when airmode is enabled Feb 3, 2025
@nerdCopter
Copy link
Member

nerdCopter commented Feb 3, 2025

when you turn it ON in CLI -- maybe need to be gray.
image

hence, hiding it did seem appropriate 😉 🤷‍♂️

@haslinghuis
Copy link
Member Author

haslinghuis commented Feb 3, 2025

Meeeh. cli should also not enable feature when AIRMODE is enabled.

EDIT: When using AIRMODE on a switch think both should be allowed exclusive (MOTOR_STOP for start / end of flight and AIRMODE in flight)

@haslinghuis
Copy link
Member Author

See betaflight/betaflight#14236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

The relation between MOTOR_STOP and AIRMODE should be better documented
3 participants