-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable motor stop feature when airmode is enabled #4326
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for origin-betaflight-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
So you are more inclined to have it hidden. Well, if that is a better option compared to have it disabled, then let it be. |
@dmak did not know it was exclusive. So makes sense to hide it in configurator. But still like the info to be in documentation too. |
Well, my idea was that if control is disabled, the user may click on (?) button or navigate to wiki to get more info about why it is disabled. If it is hidden then it rings no bell 😉 |
i can predict many |
Quality Gate passedIssues Measures |
Meeeh. cli should also not enable feature when AIRMODE is enabled. EDIT: When using AIRMODE on a switch think both should be allowed exclusive (MOTOR_STOP for start / end of flight and AIRMODE in flight) |
This pull request includes an update to the
motors.initialize
function in thesrc/js/tabs/motors.js
file to enhance the handling of the ESC motor stop feature.Improvements to ESC motor stop handling:
src/js/tabs/motors.js
: Modified the.escMotorStop
element to disable theinput#feature4
input if the "AIRMODE" feature is enabled.