Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ports-tab SerialRX help-tip #4324

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Ports-tab SerialRX help-tip #4324

merged 2 commits into from
Feb 4, 2025

Conversation

nerdCopter
Copy link
Member

@netlify Netlify
Copy link

netlify bot commented Jan 31, 2025 •
edited
Loading

✅ Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit 8992878
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/679d082d832ca50008e089e3
😎 Deploy Preview https://deploy-preview-4324.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nerdCopter
Copy link
Member Author

During this modification, it was noticed that the thead used td as sub-components, whereas th is the proper component. Changing such required modifying the css as well. Additionally changing to th required the use of a span so that the help-icon would not be hidden or incorrectly arranged above the table. Future help-tips per header will require the same. Bold headers were an unexpected but welcome outcome.

@haslinghuis haslinghuis added this to the 11.0 milestone Jan 31, 2025
@haslinghuis
Copy link
Member

Perhaps we use Control Link or Remote Control instead of Serial Rx

@nerdCopter
Copy link
Member Author

Perhaps we use Control Link or Remote Control instead of Serial Rx

Perhaps, but column width should remain rather small and community is accustomed to existing terminology. Another option is Receiver only, but 🤷‍♂️

@haslinghuis
Copy link
Member

RC link would be even shorter - but we'll probably leave it as it is. 😛

@nerdCopter nerdCopter marked this pull request as ready for review January 31, 2025 19:26
VitroidFPV
VitroidFPV approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@VitroidFPV VitroidFPV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the hint like this, leaving merge-ready for any last minute suggestions

@haslinghuis haslinghuis merged commit 4d8587b into betaflight:master Feb 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VitroidFPV VitroidFPV VitroidFPV approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

Assignees

@nerdCopter nerdCopter

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.6 Release
Status: Done
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

Change the name of Serial Rx column
3 participants
@nerdCopter @haslinghuis @VitroidFPV