Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display either flash or sdcard #4290

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Jan 1, 2025

  • Show flash or sdcard storage depending on selected device.
  • 1st commit changes line 23+24 - other changes are from prettier.
  • 2nd commit adds line 683 to serial_backend - other changes are from prettier

@haslinghuis haslinghuis added this to the 11.0 milestone Jan 1, 2025
@haslinghuis haslinghuis self-assigned this Jan 1, 2025
Copy link

netlify bot commented Jan 1, 2025

Deploy Preview for origin-betaflight-app ready!

Name Link
🔨 Latest commit a597c8f
🔍 Latest deploy log https://app.netlify.com/sites/origin-betaflight-app/deploys/6775ec17fd7a470008550f92
😎 Deploy Preview https://deploy-preview-4290.dev.app.betaflight.com
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SteveCEvans
Copy link
Member

On the setup tab no flash/SD capacity is displayed.

image

Switching to the Blackbox tab results in the correct value being displayed thus:

image

Or:

image

However there is a slight delay before this value is displayed; I've have expected it to be pretty much instant.

@haslinghuis
Copy link
Member Author

@SteveCEvans should be fixed now.

Copy link
Member

@SteveCEvans SteveCEvans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested working on an ORBITF435.

@haslinghuis haslinghuis requested a review from blckmn January 2, 2025 00:32
Copy link

sonarqubecloud bot commented Jan 2, 2025

@haslinghuis haslinghuis merged commit 6fbeb83 into betaflight:master Jan 2, 2025
9 checks passed
@haslinghuis haslinghuis deleted the blackbox-storage branch January 2, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants