Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

motor direction tools: gui_log the direction clicked #3634

Merged
merged 3 commits into from
Nov 15, 2023
Merged

motor direction tools: gui_log the direction clicked #3634

merged 3 commits into from
Nov 15, 2023

Conversation

nerdCopter
Copy link
Member

@nerdCopter nerdCopter commented Nov 14, 2023 •
edited
Loading

  • requested by @darkmann
  • reused existing locale

2023-11-14_13-44
ignore the missing graphic, it is a side effect of unfinished PWA (vite).

@haslinghuis haslinghuis added this to the 10.10.0 milestone Nov 14, 2023
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@blckmn
Copy link
Member

blckmn commented Nov 14, 2023

AUTOMERGE: (FAIL)

  • github identifies PR as mergeable -> FAIL
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> FAIL
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> FAIL
  • assigned to an approver -> FAIL
  • approver count at least three -> FAIL

@nerdCopter nerdCopter marked this pull request as draft November 14, 2023 18:46
@nerdCopter
Copy link
Member Author

marking as draft, i should de-duplicate a bit

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions GitHub Actions
Copy link
Contributor

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

@nerdCopter nerdCopter marked this pull request as ready for review November 14, 2023 20:24
@haslinghuis haslinghuis merged commit 86043fa into betaflight:master Nov 15, 2023
chmelevskij pushed a commit to chmelevskij/betaflight-configurator that referenced this pull request Apr 27, 2024
@nerdCopter @haslinghuis @chmelevskij
motor direction tools: gui_log the direction clicked (betaflight#3634)
10f5df9 
* motor direction tools: gui_log the direction clicked

* motor direction tools: gui_log the direction clicked ; fix syntax

* motor direction tools: gui_log the direction clicked ; deduplicate/simplify

---------

Co-authored-by: Mark Haslinghuis <mark@numloq.nl>
@nerdCopter nerdCopter deleted the 20231114_log_motor_changes branch October 31, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chmelevskij chmelevskij chmelevskij approved these changes

@haslinghuis haslinghuis haslinghuis approved these changes

@McGiverGim McGiverGim Awaiting requested review from McGiverGim

@asizon asizon Awaiting requested review from asizon

Assignees

@nerdCopter nerdCopter

Labels
RN: IMPROVEMENT
Projects
Finalizing Firmware 4.5 Release
Status: COMPLETED
Milestone
10.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nerdCopter @blckmn @chmelevskij @haslinghuis