Add all 8 debug values in sensors tab and only show active debugs

[haslinghuis]

Spoiler

Once a debug != 0 it will show up persistent.

[haslinghuis]

BTFL_BLACKBOX_LOG_GPSM10.zip

[blckmn]

AUTOMERGE: (FAIL)

• github identifies PR as mergeable -> FAIL
• assigned to a milestone -> PASS
• cooling off period lapsed -> PASS
• commit count less or equal to three -> FAIL
• Don't merge label NOT found -> PASS
• at least one RN: label found -> PASS
• Tested label found -> FAIL
• assigned to an approver -> PASS
• approver count at least three -> FAIL

[limonspb]

Does it work ok, if old firmware is connected with 4 values only?

[haslinghuis]

I guess only some DEBUG sets contain all 8 values. Try GPS_UNIT_CONNECTION (testing with #12799

[nerdCopter]

retested.
#3522 shows 8 debugs on sensors tab no matter what firmware. (0-7).

[haslinghuis]

Change was made in #12445 so it should only apply to API 1.46 and above. But that would require a lot of work :(

The rows are at the bottom so they are not too disturbing imho.

[haslinghuis]

Ok did it :)

[nerdCopter]

i will test 40bc6e3 when i can, i was working on something as well, but upon failure, i quit.
it does not work, but may show where i was aiming: diff.txt

[haslinghuis]

Fixed :)

[haslinghuis]

Forgot the .gte after refactoring the line from an if statement.

sensors.debugColumns = semver.gte(FC.CONFIG.apiVersion, API_VERSION_1_46) ? 8 : 4;

[nerdCopter]

• i believe this is working as expected. (as coded)

• i do see a strange behavior, maybe it is desired. where if there is no data, it will not display.

  • example: i have no baro, set debug = baro; no graph
  • example: set debug = antigravity; no graph 0,1, but shows graph 2,3

  edit: this test before new commit 68efcbd

[haslinghuis]

Yes that's the dynamic part. Only when there is data the column is enabled for the whole session to hide inactive debug data (only 0)

[nerdCopter]

• tested 4.5 master
• tested 4.3.2
• seems as expected
• maybe request other testers as well (have them enable console)

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[haslinghuis]

Rebased on master

[github-actions]

Do you want to test this code? Here you have an automated build:
Betaflight-Configurator-Android
Betaflight-Configurator-Linux
Betaflight-Configurator-macOS
Betaflight-Configurator-Windows
WARNING: It may be unstable and result in corrupted configurations or data loss. Use only for testing!

[ctzsnooze]

Not sure that the logic within only show active debugs is totally reliable, but having all 8 is awesome!