Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump NWjs to 0.54.1 #2548

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Bump NWjs to 0.54.1 #2548

merged 1 commit into from
Aug 31, 2021

Conversation

haslinghuis
Copy link
Member

@haslinghuis haslinghuis commented Aug 2, 2021 •
edited
Loading

Bumps NWjs from 0.54.0 to 0.54.1 fixing an issue with not being able to select a custom image using Font Manager.

Also tried 0.55.0 but @kevinsummer pointed out a problem with registering the Notification Center App ID as io.nwjs.nwjs.framework.alertnotificationservice instead of com.nw-builder.betaflight-configurator.

See #2274

@haslinghuis haslinghuis added this to the 10.8.0 milestone Aug 2, 2021
@haslinghuis haslinghuis self-assigned this Aug 2, 2021
@McGiverGim
Copy link
Member

We try to use same version for Configurator and Blackbox. Is there a similar PR in the other repo?

@haslinghuis
Copy link
Member Author

haslinghuis commented Aug 2, 2021 •
edited
Loading

@McGiverGim it's on 0.50.2 now instead of 0.54.0 😕

@haslinghuis haslinghuis mentioned this pull request Aug 2, 2021
Merged
@asizon
Copy link
Member

asizon commented Aug 3, 2021

Because Mikellers 0.54 PR not yet merged :(
betaflight/blackbox-log-viewer#518

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@haslinghuis haslinghuis changed the title Bump NWjs to 0.55.0 Bump NWjs to 0.54.1 Aug 4, 2021
@asizon
Copy link
Member

asizon commented Aug 15, 2021

@haslinghuis why you are not using 0.55 here and in bb part? seems that ffmpg 0.55 library version is avaiable.

@haslinghuis
Copy link
Member Author

Using the ffmpeg prebuilt library 0.55.0 now.
NWjs 0.55.0 was not working as 0.54.1 does.
Also tested with Node 16 on Linux without problem. Windows and OSX is not working with Node 14 / 16.

@asizon asizon added the Tested label Aug 22, 2021
@blckmn
Copy link
Member

blckmn commented Aug 31, 2021

AUTOMERGE: (PASS)

  • github identifies PR as mergeable -> PASS
  • assigned to a milestone -> PASS
  • cooling off period lapsed -> PASS
  • commit count less or equal to three -> PASS
  • Don't merge label NOT found -> PASS
  • at least one RN: label found -> PASS
  • Tested label found -> PASS
  • assigned to an approver -> PASS
  • approver count at least three -> PASS

@blckmn blckmn merged commit a2d0fa9 into betaflight:master Aug 31, 2021
@haslinghuis haslinghuis deleted the update-nwjs branch August 31, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McGiverGim McGiverGim McGiverGim approved these changes

@mikeller mikeller mikeller approved these changes

@blckmn blckmn blckmn approved these changes

@ctzsnooze ctzsnooze ctzsnooze approved these changes

@asizon asizon asizon approved these changes

Assignees

@haslinghuis haslinghuis

Labels
RN: IMPROVEMENT Tested
Projects
None yet
Milestone
10.8.0
Development

Successfully merging this pull request may close these issues.
6 participants
@haslinghuis @McGiverGim @asizon @blckmn @mikeller @ctzsnooze