Key search #83
Merged
Key search #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the old funtionality it was OK to always need a node, because a user had to choose one after choosing an environment. With #4 we are introducing a different funtionality that should work indepently of a node. This is in preparation of #4 and tries to disentangle environment, nodes and everything else. To accomplish this, "proper" abstractions for all relevant parts of the hiera data model are introduced (hierarchies, data_files and values). Due to the git backend, (data_)file and value handling still need to be able to work with a node's facts, but this has been made optional.
|
Can you please specify how the ui is going to look if you have several (maybe 50, maybe 100) node specific yaml files which have the key inside? |
|
It is a long list then:
|
|
Lists of files may get very long. This way, a user can open just the hierarchy she wants.
|
Hierarchies are now collapsed by default. Also, I added a few tests. This should be ready now. Fixes #4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a first draft of the key search feature.
After selecting an environment, one can now choose a node as before or search for key:
When searching for a key a results page is displayed that mostly copies the UI we already have for nodes:
Clicking on a file name opens up the display of the actual value, just as in the node view:
This includes a massive refactoring of a lot of things. I am mostly happy with this, except for the git backend "problem" we talked about.
When this looks like it is going in the right direction, I would like to add a couple more tests.