Allow disabling of authentication #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change you can set `authentication_disabled` to `true` in `hdm.yml` to bypass authentication.
Also fix rubocop violations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #54
I took the commit referenced there, rebased against
mainand added a few tests.This now allows to disable authentication by setting
authentication_disabled: trueinconfig/hdm.yml.What is missing in my opinion is an example of this in either
config/hdm.yml.templateor the documentation. But I was not sure where a suitable place would be. Also I am not 100% sure how this will be used or is supposed to be used (like is this more adevelopmentthing or will it be used inproductionprimarily?). So you might want to add this.(Please note: We talked about adding
fixes #[issue number]to PRs, so issues can be closed automatically. I did not do this here on purpose because I am not certain all requirements of #54 are met when this is merged.)