Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update libp2p #72

Merged
merged 2 commits into from
Jun 21, 2023
Merged

fix: update libp2p #72

merged 2 commits into from
Jun 21, 2023

Conversation

matubu
Copy link
Member

@matubu matubu commented May 26, 2023

Upgrade libp2p to fix crash (berty/berty#4686) in berty when the phone is unlock

@guardrails
Copy link

guardrails bot commented May 26, 2023

⚠️ We detected 4 security issues in this pull request:

Vulnerable Libraries (4)
Severity Details
N/A pkg:golang/github.com/multiformats/go-multiaddr@v0.9.0@v0.9.0 - no patch available
N/A pkg:golang/github.com/ipfs/go-cid@v0.4.1@v0.4.1 - no patch available
N/A pkg:golang/github.com/libp2p/go-libp2p@v0.27.3@v0.27.3 - no patch available
N/A pkg:golang/go.uber.org/multierr@v1.11.0@v1.11.0 - no patch available

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@matubu @gfanton
chore: update libp2p
82e525a 
Signed-off-by: u <hi@mathias.ninja>
@jefft0
Copy link
Contributor

jefft0 commented Jun 16, 2023 •
edited
Loading

Convert to draft while waiting for gfanton to update libp2p mocknet.

@jefft0 jefft0 marked this pull request as draft June 16, 2023 13:49
@gfanton gfanton force-pushed the chore/update_libp2p branch from ff2640b to deaf8c9 Compare June 20, 2023 07:41
@gfanton gfanton marked this pull request as ready for review June 20, 2023 07:41
@gfanton
fix: use berty custom mocknet
ea21b64 
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton force-pushed the chore/update_libp2p branch from deaf8c9 to ea21b64 Compare June 20, 2023 14:15
@D4ryl00
Copy link
Collaborator

D4ryl00 commented Jun 20, 2023 •
edited
Loading

github.com/libp2p/go-libp2p/p2p/net/mock still exist, why don't we try to adapt our code to their new mock API instead of cloning their old mock struct?
Because, if we keep a mock code, so unsync with the libp2p code, we will have to update it in the future if libp2p also changes their code.

@gfanton
Copy link
Member

gfanton commented Jun 21, 2023

@D4ryl00 They simply don't plan to maintain it anymore we should actually plan to remove it from weshnet and use a simple host instead, see: libp2p/go-libp2p#2267

D4ryl00
D4ryl00 approved these changes Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@D4ryl00 D4ryl00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfanton gfanton merged commit 15bbf0d into berty:main Jun 21, 2023
@github-actions
Copy link

🎉 This PR is included in version 1.10.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuricmp iuricmp iuricmp approved these changes

@D4ryl00 D4ryl00 D4ryl00 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matubu @jefft0 @D4ryl00 @gfanton @iuricmp