This repository has been archived by the owner on Jul 30, 2021. It is now read-only.
New receive #41
Open
New receive #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… implementation weakness
…e of _error in setErrorResponse()
|
Whoa! This took me a while. I completely missed the examples and Test sections, plus I do definitely disagree with some of cpplint's rules. A good thing was cppcheck mentioning I was using a lazy Anyway, done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new receive mechanism and the rawRequest are working okay for me since a day now. The commits I applied in the last 24 hours were only cosmetics ;)
Please note: this PR is built on top of the previous "Token" PR.