lint fixes for various tools #107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
5 tasks
bernt-matthias
force-pushed
the
topic/skip_lint
branch
from
86a7364 to
9882d51
Compare
| @@ -52,24 +52,24 @@ | |||
| </outputs> | |||
|
|
|||
| <tests> | |||
| <test><!-- Test 1 --> | |||
| <test expect_num_outputs="1"><!-- Test 1 --> | |||
There was a problem hiding this comment.
Guess we can remove a linter rule from the skip file.
We should bump and deploy this one (so maybe better put in a separate PR)?
There was a problem hiding this comment.
Not sure a deployment is needed here? I would not deploy for a stricter test. Please feel free to merge and take it from here.
Co-authored-by: M Bernt <m.bernt@ufz.de>
|
@bernt-matthias what do you want me to do with this one? |
| <expand macro="requirements" /> | ||
| <expand macro="version_command" /> | ||
|
|
||
| <expand macro="edam_ontology"/> |
There was a problem hiding this comment.
If we fix a linter error we should remove it from the tool's .lint_skip file.
There was a problem hiding this comment.
abcriacte didn't had a lint_skip file imho
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FOR CONTRIBUTOR: