Updated build instructions #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jakub, thanks much for the PR. Alas I had already submitted a competing PR earlier. I'm working on it right now to also include code formatting tests which are failing at the moment. I'll put your PR on hold for now until that one has passed. |
|
Yeah, I've just noticed #7 . No problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @berndpfrommer discovered when solving an issue of missing ament_cmake_clang_format, the build instructions were according to him outdated.
As a result, README was modified to only set env variables with a link to unified build instructions, independent of the specific repo.
The first commit addresses a typo: pkg=frequency_cam.
The second one proposes similar instructions to those that were used to solve the mentioned
cmakeissue.