Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

berks shelf show should take an optional VERSION argument #586

Merged
merged 2 commits into from
May 30, 2013
Merged

berks shelf show should take an optional VERSION argument #586

merged 2 commits into from
May 30, 2013

Conversation

sethvargo
Copy link
Contributor

The berks shelf show command should take an optional VERSION argument

  • If not provided, information about the latest version of the cookbook will be shown
  • If it is provided, information about that version of the cookbook will be shown

@reset reset mentioned this pull request May 29, 2013
@ghost ghost assigned sethvargo May 29, 2013
@sethvargo
Copy link
Contributor

@reset this is already done, but I changed this into a PR to fix a small bug when the passed version does not exist and expanded the test cases.

When I run `berks shelf show fake --version 1.2.3`
Then the output should contain:
"""
Cookbook 'fake' is not in the Berkshelf shelf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incorrect statement. Shouldn't it be "Version 1.2.3 of fake is not in the shelf"?

@ivey
Copy link
Contributor

ivey commented May 29, 2013

Are you going to drop the -v aliases on show and delete here, or in a separate PR?

@reset
Copy link
Contributor Author

reset commented May 29, 2013

@ivey @sethvargo doesn't matter where it happens, but -v should be removed as an alias on any of our commands since it's also used for --version

@sethvargo
Copy link
Contributor

@reset @ivey -v and --version are both already used. In this case, thor "does the right thing" and chooses the method option over the map. I think this is the preferred behavior, as that's how gem works too:

$ gem -v
1.8.23
$ gem install berkshelf -v 1.4.4
Fetching: yajl-ruby-1.1.0.gem (100%)
Building native extensions.  This could take a while...
Fetching: berkshelf-1.4.4.gem (100%)
Successfully installed yajl-ruby-1.1.0
Successfully installed berkshelf-1.4.4
2 gems installed

@reset
Copy link
Contributor Author

reset commented May 29, 2013

As long is there's no conflict I'm ok with it. @ivey?

@sethvargo
Copy link
Contributor

@reset @ivey fixed those issues with the output being inconsistent.

@ivey
Copy link
Contributor

ivey commented May 30, 2013

I'm fine with it if it works.

reset added a commit that referenced this pull request May 30, 2013
`berks shelf show` should take an optional VERSION argument
@reset reset merged commit 0325321 into berkshelf:master May 30, 2013
@sethvargo sethvargo deleted the shelf_show_version branch May 30, 2013 05:13
@berkshelf berkshelf locked and limited conversation to collaborators Jun 16, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants