-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
berks shelf show
should take an optional VERSION argument
#586
Conversation
@reset this is already done, but I changed this into a PR to fix a small bug when the passed version does not exist and expanded the test cases. |
When I run `berks shelf show fake --version 1.2.3` | ||
Then the output should contain: | ||
""" | ||
Cookbook 'fake' is not in the Berkshelf shelf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an incorrect statement. Shouldn't it be "Version 1.2.3 of fake is not in the shelf"?
Are you going to drop the |
@ivey @sethvargo doesn't matter where it happens, but |
@reset @ivey
|
As long is there's no conflict I'm ok with it. @ivey? |
I'm fine with it if it works. |
`berks shelf show` should take an optional VERSION argument
The
berks shelf show
command should take an optional VERSION argument