Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression by updating Cargo.toml to depend on mio-serial 5.0.2 #49

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

astraw
Copy link
Contributor

@astraw astraw commented Mar 23, 2022

This fixes ff8d9ec, which introduces a
dependency on mio-serial 5.0.2 but did not bump the version requirement
in Cargo.toml. Without also updating Cargo.toml to depend on mio-serial
5.0.2, upgrading a project with an old lock file to latest tokio-serial will break with

error[E0432]: unresolved imports `mio_serial::SerialPortType`, `mio_serial::UsbPortInfo`
  --> /builds/straw/proj/.cargo-proj/registry/src/github.com-1ecc6299db9ec823/tokio-serial-5.4.2/src/lib.rs:13:40
   |
13 |     SerialPortBuilder, SerialPortInfo, SerialPortType, StopBits, UsbPortInfo,
   |                                        ^^^^^^^^^^^^^^            ^^^^^^^^^^^ no `UsbPortInfo` in the root
   |                                        |
   |                                        no `SerialPortType` in the root
   |                                        help: a similar name exists in the module: `SerialPort`

@estokes estokes merged commit f9b0aa7 into berkowski:master Mar 23, 2022
@estokes
Copy link
Collaborator

estokes commented Mar 23, 2022

Oops

@astraw
Copy link
Contributor Author

astraw commented Mar 23, 2022

Thanks for the quick fix and new release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants