Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export SerialPortType and UsbPortInfo from mio-serial #48

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Re-export SerialPortType and UsbPortInfo from mio-serial #48

merged 1 commit into from
Feb 22, 2022

Conversation

mettz
Copy link
Contributor

@mettz mettz commented Feb 21, 2022

This PR re-exports some types to allow the user to use the port_type field of SerialPortInfo. However it can be merged only once berkowski/mio_serial#28 has been merged

@estokes
Copy link
Collaborator

estokes commented Feb 21, 2022

Thanks for taking the time to do this. We're still getting up to speed as the new maintainers of this crate, so bear with us. I know it seems like a trivial change, but I want to give some thought to whether these exports make sense, once you expose things you can't easily unexpose them.

@estokes estokes merged commit 554fab8 into berkowski:master Feb 22, 2022
@mettz
Copy link
Contributor Author

mettz commented Feb 27, 2022

Hi @estokes, do you have any ideas about when the next releases (both of tokio-serial and mio-serial) with the re-exported types will be available on crates.io?

@estokes
Copy link
Collaborator

estokes commented Feb 27, 2022 via email

@estokes
Copy link
Collaborator

estokes commented Feb 27, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants