Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to 5.4.0-beta1 #42

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Conversation

ColinFinck
Copy link
Collaborator

Removes no longer required dependencies and fix some comments.

Apart from that, 5.4.0-beta1 looks fine to me. Did you really want to release that as 5.4.0 though and not 4.4.0 or 5.0?
I guess, you could still yank the 5.4.0-beta1 release from crates.io and change the version number if required.

@berkowski
Copy link
Owner

Breaking API changes should require a major version bump if playing by semver rules. Ideally I'd use v4.4.0 for this, but v4.3 was already released with the old API.

@ColinFinck
Copy link
Collaborator Author

Fair enough. 5.4.0 then or 5.0.0?

@berkowski
Copy link
Owner

The old version scheme was $MIO_SERIAL_MAJOR.$SERIALPORT-RS_MAJOR.$TOKIO_SERIAL_PATCH as the tokio stuff is really just a wrapper around mio, and the mio API is heavily influenced by serialport-rs.

I guess if I want to stick to this I could skip a v4 release of mio-serial and go direct to v5 which would keep the versions more in sync

@ColinFinck
Copy link
Collaborator Author

Now I understand 5.4.0, thanks. Is this PR alright?

src/lib.rs Show resolved Hide resolved
@berkowski
Copy link
Owner

PR looks good pending the small change named in my comment. I've been holding of merging it until I finish bashing my head against CI test infrastructure on mio-serial

@ColinFinck ColinFinck requested a review from berkowski July 19, 2021 07:12
@berkowski berkowski merged commit 2986b97 into berkowski:master Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants