Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit cookieSecret and proxy.secretToken for staging #2381

Merged
merged 1 commit into from
May 5, 2021

Conversation

yuvipanda
Copy link
Contributor

With jupyterhub/zero-to-jupyterhub-k8s#1993,
these are no longer required to be explicitly set. We remove
both just for staging hubs - doing so for production
hubs will cause everyone to be logged out (cookieSecret) and
temporarily disconnected (proxy.secretToken) so we aren't
doing that yet

With jupyterhub/zero-to-jupyterhub-k8s#1993,
these are no longer required to be explicitly set. We remove
both just for staging hubs - doing so for production
hubs will cause everyone to be logged out (cookieSecret) and
temporarily disconnected (proxy.secretToken) so we aren't
doing that yet
@yuvipanda
Copy link
Contributor Author

Ok, so to rotate the secrets, you need to:

  1. Delete the hub secret in each namespace,
  2. Do a deploy.

I've turned off CircleCI for now, so this is manual.

I've deleted the hub secret with:

 k get ns | rg staging | awk '{ print $1 }' | parallel k delete secret hub -n

And am deploying with:

ls deployments | xargs -I{} -L1 hubploy deploy {} hub staging   

@yuvipanda
Copy link
Contributor Author

I've just paid for CircleCI out of pocket so we can have it again in private.

@yuvipanda yuvipanda merged commit 5d87b72 into staging May 5, 2021
yuvipanda added a commit to yuvipanda/datahub-old-fork that referenced this pull request May 5, 2021
Follow-up to berkeley-dsep-infra/datahub#2381.
I verified that this doesn't *actually* rotate the secrets
themeselves - just removes them from git. This just reduces
the amount of secret data we store here.

See jupyterhub/zero-to-jupyterhub-k8s#1993
for more info on what is happening here.
yuvipanda added a commit that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant