Skip to content

Commit

Permalink
Revert "ignore 5 pester failure on Ubuntu for AppVeyor due Pester/Pow…
Browse files Browse the repository at this point in the history
…erShell bug that happens on AppVeyor environment"

This reverts commit 8c48e93.
  • Loading branch information
bergmeister committed Dec 29, 2018
1 parent 5789ea1 commit f4e4441
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 12 deletions.
14 changes: 7 additions & 7 deletions Tests/Documentation/RuleDocumentation.tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -35,29 +35,29 @@ Describe "Validate rule documentation files" {
$rulesReadmeDiff = Compare-Object -ReferenceObject $rules -DifferenceObject $readmeRules -SyncWindow 25
}

It "Every rule must have a rule documentation file" -Skip:($env:APPVEYOR -and $IsLinux) {
It "Every rule must have a rule documentation file" {
$rulesDocsDiff | Where-Object SideIndicator -eq "<=" | Foreach-Object InputObject | Should -BeNullOrEmpty
}
It "Every rule documentation file must have a corresponding rule" -Skip:($env:APPVEYOR -and $IsLinux) {
It "Every rule documentation file must have a corresponding rule" {
$rulesDocsDiff | Where-Object SideIndicator -eq "=>" | Foreach-Object InputObject | Should -BeNullOrEmpty
}

It "Every rule must have an entry in the rule documentation README.md file" -Skip:($env:APPVEYOR -and $IsLinux) {
It "Every rule must have an entry in the rule documentation README.md file" {
$rulesReadmeDiff | Where-Object SideIndicator -eq "<=" | Foreach-Object InputObject | Should -BeNullOrEmpty
}
It "Every entry in the rule documentation README.md file must correspond to a rule" -Skip:($env:APPVEYOR -and $IsLinux) {
It "Every entry in the rule documentation README.md file must correspond to a rule" {
$rulesReadmeDiff | Where-Object SideIndicator -eq "=>" | Foreach-Object InputObject | Should -BeNullOrEmpty
}

It "Every entry in the rule documentation README.md file must have a valid link to the documentation file" -Skip:($env:APPVEYOR -and $IsLinux) {
It "Every entry in the rule documentation README.md file must have a valid link to the documentation file" {
foreach ($key in $readmeLinks.Keys) {
$link = $readmeLinks[$key]
$filePath = Join-Path $ruleDocDirectory $link
$filePath | Should -Exist
}
}

It "Every rule name in the rule documentation README.md file must match the documentation file's basename" --Skip:($env:APPVEYOR -and $IsLinux) {
It "Every rule name in the rule documentation README.md file must match the documentation file's basename" {
foreach ($key in $readmeLinks.Keys) {
$link = $readmeLinks[$key]
$filePath = Join-Path $ruleDocDirectory $link
Expand Down
2 changes: 1 addition & 1 deletion Tests/Engine/InvokeScriptAnalyzer.tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ Describe "Test -Fix Switch" {
}

Describe "Test -EnableExit Switch" {
It "Returns exit code equivalent to number of warnings" -Skip:($env:APPVEYOR -and $IsLinux) {
It "Returns exit code equivalent to number of warnings" {
if ($IsCoreCLR) {
pwsh -command 'Import-Module PSScriptAnalyzer; Invoke-ScriptAnalyzer -ScriptDefinition gci -EnableExit'
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/Rules/AvoidUsingAlias.tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ Configuration MyDscConfiguration {
$violations.Count | Should -Be 1
}

It "honors the whitelist in a case-insensitive manner" -Skip:($env:APPVEYOR -and $IsLinux) {
It "honors the whitelist in a case-insensitive manner" {
$violations = Invoke-ScriptAnalyzer -ScriptDefinition "CD" -Settings $settings -IncludeRule $violationName
$violations.Count | Should -Be 0
}
Expand Down
6 changes: 3 additions & 3 deletions Tests/Rules/UseDSCResourceFunctions.tests.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ if ($PSVersionTable.PSVersion -ge [Version]'5.0.0')
}

Describe "StandardDSCFunctionsInResource" {
Context "When there are violations" {
It "has 1 missing standard DSC functions violation" -Skip:($env:APPVEYOR -and $IsLinux) {
Context "When there are violations" {
It "has 1 missing standard DSC functions violation" {
$violations.Count | Should -Be 1
}

It "has the correct description message" -Skip:($env:APPVEYOR -and $IsLinux) {
It "has the correct description message" {
$violations[0].Message | Should -Match $violationMessage
}
}
Expand Down

0 comments on commit f4e4441

Please sign in to comment.