feat(simulated): Add Simulation Client for EVM State Transitions (4/n) #2554
+753
−147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t into simulated-blob-tests
rezbera
commented
Mar 4, 2025
| --authrpc.addr 0.0.0.0 \ | ||
| --authrpc.jwtsecret /testing/files/jwt.hex \ | ||
| --authrpc.vhosts '*' \ | ||
| --datadir /tmp/gethdata \ | ||
| --ipcpath /tmp/gethdata/geth.ipc \ | ||
| --syncmode full \ | ||
| --verbosity 4 | ||
| --verbosity 4 \ | ||
| --nodiscover |
There was a problem hiding this comment.
nodiscover as peer discovery is not required
calbera
reviewed
Mar 5, 2025
There was a problem hiding this comment.
nit: rename to simulation_client.go? or sim_client.go?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary unlock from this PR is the ability to do tests like
TestFullLifecycle_ValidBlockWithInjectedTransaction_IsSuccessful, in which we can inject custom transactions and create valid blocks that pass processing which was previously not possibly.To do this, we must introduce the simulation client, which utilises
eth_simulateV1to calculate the EVM state and receipts roots for a given block. These fields are necessary to correctly passNewPayloadvalidation.The
eth_simulateV1API is currently missing features we require which I hope to have merged in upstream geth ethereum/go-ethereum#31304Till then, we have to use a custom image which I've built based on the linked PR. Once upstream is merged and released, we can go back to the original image.