Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(engine api): [1/3] error on engine API errors (revive #2485) #2508

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shotes
Copy link
Contributor

@shotes shotes commented Feb 12, 2025

Revives #2485

@shotes shotes requested a review from a team as a code owner February 12, 2025 22:12
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 2.17391% with 45 lines in your changes missing coverage. Please review.

Project coverage is 32.35%. Comparing base (7d43017) to head (17729e5).

Files with missing lines Patch % Lines
beacon/blockchain/execution_engine.go 0.00% 17 Missing ⚠️
beacon/blockchain/finalize_block.go 0.00% 7 Missing ⚠️
execution/engine/metrics.go 0.00% 6 Missing ⚠️
execution/engine/engine.go 0.00% 5 Missing ⚠️
payload/builder/payload.go 0.00% 5 Missing ⚠️
beacon/validator/block_builder.go 0.00% 2 Missing ⚠️
state-transition/core/state_processor_payload.go 0.00% 2 Missing ⚠️
beacon/blockchain/process_proposal.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2508      +/-   ##
==========================================
+ Coverage   32.24%   32.35%   +0.10%     
==========================================
  Files         350      350              
  Lines       15653    15595      -58     
  Branches       20       20              
==========================================
- Hits         5047     5045       -2     
+ Misses      10243    10187      -56     
  Partials      363      363              
Files with missing lines Coverage Δ
consensus-types/types/payload_requests.go 76.53% <ø> (-0.24%) ⬇️
primitives/transition/context.go 0.00% <ø> (ø)
testing/state-transition/state-transition.go 84.37% <100.00%> (-0.25%) ⬇️
beacon/blockchain/process_proposal.go 0.00% <0.00%> (ø)
beacon/validator/block_builder.go 0.00% <0.00%> (ø)
state-transition/core/state_processor_payload.go 26.92% <0.00%> (+0.25%) ⬆️
execution/engine/engine.go 0.00% <0.00%> (ø)
payload/builder/payload.go 20.12% <0.00%> (-0.40%) ⬇️
execution/engine/metrics.go 0.00% <0.00%> (ø)
beacon/blockchain/finalize_block.go 0.00% <0.00%> (ø)
... and 1 more

@calbera calbera changed the title Revert "Revert "fix(engine api): [1/3] error on engine API errors (#2485)"" fix(engine api): [1/3] error on engine API errors (#2485) Feb 12, 2025
@calbera calbera changed the title fix(engine api): [1/3] error on engine API errors (#2485) fix(engine api): [1/3] error on engine API errors (revive #2485) Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant