-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cli): Refactor CollectGenesisDeposits to be callable from runtime #2464
Conversation
return cmd | ||
} | ||
|
||
func CollectGenesisDeposits(config *cmtcfg.Config) error { | ||
appGenesis, err := genutiltypes.AppGenesisFromFile( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy paste of logic
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2464 +/- ##
==========================================
- Coverage 32.28% 32.27% -0.01%
==========================================
Files 350 350
Lines 15634 15636 +2
Branches 20 20
==========================================
Hits 5047 5047
- Misses 10224 10226 +2
Partials 363 363
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This supports the #2411 by allowing for the collect-deposits to be runnable in runtime.
No change in core logic or external UX.