Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): Refactor CollectGenesisDeposits to be callable from runtime #2464

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

rezbera
Copy link
Contributor

@rezbera rezbera commented Feb 3, 2025

This supports the #2411 by allowing for the collect-deposits to be runnable in runtime.

No change in core logic or external UX.

return cmd
}

func CollectGenesisDeposits(config *cmtcfg.Config) error {
appGenesis, err := genutiltypes.AppGenesisFromFile(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy paste of logic

@rezbera rezbera marked this pull request as ready for review February 3, 2025 16:01
@rezbera rezbera requested a review from a team as a code owner February 3, 2025 16:01
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 45 lines in your changes missing coverage. Please review.

Project coverage is 32.27%. Comparing base (8bd60c6) to head (7f97230).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/commands/genesis/collect.go 0.00% 45 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2464      +/-   ##
==========================================
- Coverage   32.28%   32.27%   -0.01%     
==========================================
  Files         350      350              
  Lines       15634    15636       +2     
  Branches       20       20              
==========================================
  Hits         5047     5047              
- Misses      10224    10226       +2     
  Partials      363      363              
Files with missing lines Coverage Δ
cli/commands/genesis/collect.go 0.00% <0.00%> (ø)

@rezbera rezbera enabled auto-merge (squash) February 3, 2025 16:45
@abi87 abi87 assigned abi87 and rezbera and unassigned abi87 Feb 4, 2025
Copy link
Contributor

@fridrik01 fridrik01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rezbera rezbera merged commit 5476afd into main Feb 5, 2025
19 checks passed
@rezbera rezbera deleted the minor-genesis-deposits-refactor branch February 5, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants