feat(consensus/cometbft): stable block time #2422
Open
+305
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abi87
reviewed
Jan 27, 2025
| func SetTargetBlockTime[ | ||
| LoggerT log.AdvancedLogger[LoggerT], | ||
| ](t time.Duration) func(*Service[LoggerT]) { | ||
| return func(bs *Service[LoggerT]) { bs.setTargetBlockTime(t) } |
There was a problem hiding this comment.
note that we do enforce some floor on timeouts in
There was a problem hiding this comment.
Makes sense. I will factor this in.
There was a problem hiding this comment.
It is unclear to me how to do it from the API perspective. Do you have any suggestions @abi87?
melekes
commented
Jan 31, 2025
|
|
||
| // ToBytes converts the blockDelay to bytes. | ||
| func (d *blockDelay) ToBytes() []byte { | ||
| bz, err := json.Marshal(d) |
melekes
commented
Jan 31, 2025
alesforz
approved these changes
Jan 31, 2025
melekes
added a commit
to informalsystems/beacon-kit
that referenced
this pull request
Feb 1, 2025
using FinalizeBlockResponse.NextBlockDelay feature cometbft/cometbft#3089
melekes
force-pushed
the
stable-block-time
branch
from
25c16fb to
b078dba
Compare
melekes
changed the title
|
Do we need to enforce a minimum for |
fridrik01
reviewed
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using
FinalizeBlockResponse.NextBlockDelayfeaturecometbft/cometbft#3089