chore(consensus-types): Dropped double allocation in NewFromSSZ

[abi87]

The double allocation is not needed. Dropped

Summary by CodeRabbit

• Bug Fixes
  • Streamlined the NewFromSSZ method for improved performance and consistency in handling BeaconBlock instances.
  • Enhanced error handling for unsupported fork versions, ensuring clearer responses in edge cases.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the NewFromSSZ method of the BeaconBlock struct located in mod/consensus-types/pkg/types/block.go. The modifications involve altering the instantiation of the block variable to be a pointer type, streamlining its return process by removing an unnecessary return statement, and maintaining the existing handling of unsupported fork versions.

Changes

File	Change Summary
mod/consensus-types/pkg/types/block.go	Updated NewFromSSZ method to declare block as a pointer type *BeaconBlock and streamlined return logic.

Poem

In the land of code where the rabbits play,
A method was changed in a clever way.
Pointers now dance, so sleek and so bright,
With fewer returns, it runs just right!
Hops of joy echo, as we celebrate,
For clean code brings smiles, oh isn't it great! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

📥 Commits

Files that changed from the base of the PR and between 2c99d9b and b8bb7c9.

📒 Files selected for processing (1)

• mod/consensus-types/pkg/types/block.go (1 hunks)

🔇 Additional comments (2)

mod/consensus-types/pkg/types/block.go (2)

84-88: Excellent optimization of memory allocation!

The changes successfully eliminate the unnecessary double allocation in the NewFromSSZ method. Here are the key improvements:

1. Declaring block as *BeaconBlock aligns with the method's return type, avoiding redundant allocation.
2. Directly returning block after unmarshalling simplifies the code and improves readability.
3. The logic for handling different fork versions and error cases remains intact, ensuring the method's functionality is preserved.

These changes effectively achieve the PR objective while maintaining the method's correctness.

---

84-88: Summary: Successful optimization with minimal impact

The changes in this PR effectively optimize the NewFromSSZ method by eliminating unnecessary allocation. The modification is focused and doesn't introduce any side effects or breaking changes to other parts of the file. This improvement aligns well with the PR objective and contributes to better resource management in the codebase.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.42%. Comparing base (2c99d9b) to head (b8bb7c9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   22.42%   22.42%           
=======================================
  Files         358      358           
  Lines       16012    16012           
  Branches       12       12           
=======================================
  Hits         3591     3591           
  Misses      12272    12272           
  Partials      149      149           

Files with missing lines	Coverage Δ
mod/consensus-types/pkg/types/block.go	92.72% <100.00%> (ø)